Use GitHub Approved Review to indicate r+?

#1

I’m new to Bors and still working to understand the model. I have a question which I haven’t been able to find answered anywhere.

Would consideration be given to adding a feature to Bors such that an Approved GitHub review can be the equivalent of a bors r+ command?

It seems to me that having this would be a workflow improvement as users could continue to use GitHub reviews in the way they are used to.

It looks like bonnyci and https://mergify.io both use GitHub reviews to provide the approval signal.

Any comments are appreciated!

0 Likes

#2

I’ve considered it, but for consistency’s sake I’d rather not. I know that there are people who maintain multiple projects that use bors, and if it was present as a configurable option, then that would mean that different projects would all behave differently. Clicking the GitHub Approved button and expecting it to trigger a merge, only to realize an hour later that bors was configured not to do so, stinks.

More than that, I also know that there are existing users of bors who rely on GitHub Reviews not triggering a merge, so while I don’t want it to be configurable, I also don’t want to unilaterally change bors to behave this way.

It might be a bit of a lost cause since mergify is becoming popular (BonnyCI, on the other hand, seems to be abandonware). But mergify is super-configurable, and I’ve seen other tools that exclusively use comments, or even labels, to trigger a build. I can’t make all of the build automation tools behave consistently, but I’d at least rather make bors projects consistent with each other.

If you’re looking for a way to use bors with less typing, I’ve been messing with a browser extension to add a “bors r+” button to the pull request review interface. It’s still pretty experimental, but it works when I try it.

0 Likes

#3

For what it’s worth, I just loaded it up in the Edge preview using Chromium, and it worked out of the box. Thank you!

1 Like