Ordering of commit parents & PR numbers


#1

Is there a guarantee to the ordering of the merge commit’s parents and the PR numbers listed in the commit message?

For the merges that I spot-checked, they seem to be in the same order, but I don’t really trust that, and I can’t puzzle through the code enough to be sure.


#2

Yes, they’re the same. Bors constructs the merge commit and the commit message by iterating over the same list of patches.


#3

Hmmm, I think that might not be the case. It looks like the commit message sorts the PRs by PR number, but the merge commit doesn’t.


#4

Guh, you’re right. It really needs to sort the list earlier. That’s a bug; there’s no reason for it not to have them in the same order.


#5

Fixed by