Ignoring GitHub public email for committer

joshma · May 12, 2020, 10:56pm

From what I can tell poking around the source code, it appears that Bors will use the GitHub user's public email (since that's what the GitHub API uses) when committing as a user. I think it may apply to both the Author and Committer fields, but I could be wrong.

We're hitting issues with users who use GitHub for both personal and work use, where they have a public email set to their personal email and it is appearing as the author and committer when Bors does the squash merge. (When doing this from the web UI, it uses the GitHub primary email and not public email.)

Is this an issue others have hit? Is there any way around it? Note that this works fine for those without a public email, so if it somehow just ignored the public email that would fix our issue.

dieend · September 22, 2021, 6:25pm

We also encountered the same issue.

I believe this bit of codes are the reason:

github.com

bors-ng/bors-ng/blob/fcedb9913e259e28d18e8f39f51bb2188823a6c1/lib/worker/batcher.ex#L479-L495

    
      
          {:ok, commits} = GitHub.get_pr_commits(repo_conn, patch_link.patch.pr_xref)
          {:ok, pr} = GitHub.get_pr(repo_conn, patch_link.patch.pr_xref)
          
          
{token, _} = repo_conn
          user = GitHub.get_user_by_login!(token, pr.user.login)
          
          
Logger.debug("PR #{inspect(pr)}")
          Logger.debug("User #{inspect(user)}")
          
          
# If a user doesn't have a public email address in their GH profile
          # then get the email from the first commit to the PR
          user_email =
            if user.email != nil do
              user.email
            else
              Enum.at(commits, 0).author_email
            end

The get_user_by_login use the following GitHub API Users - GitHub Docs and return null when it's not being set.

Any idea on how to work around it?