Crash during batch


#1

Hi,

New user… I have been evaluating bors this week and hit a crash situation. I had some PR’s merge successfully, but wanted to try a more complicated scenario. I created a batch of PR’s with one that I new would create a conflict. I figured I would try here first, before debugging, but I would expect that the tool could handle this situation and would post a useful message. I am using version 0.1.0 from docker.
Thanks for the help.

7/13/2018, 11:08:23 AM Batch Canceled #3
7/13/2018, 11:08:23 AM Crash batch
{{:badmatch, {:error, :push}},
[{BorsNG.GitHub, :push!, 3,
[file: ‘lib/github/github.ex’, line: 63]},
{BorsNG.Worker.Batcher, :complete_batch, 3,
[file: ‘lib/worker/batcher.ex’, line: 381]},
{BorsNG.Worker.Batcher, :maybe_complete_batch, 1,
[file: ‘lib/worker/batcher.ex’, line: 368]},
{BorsNG.Worker.Batcher, :handle_cast, 2,
[file: ‘lib/worker/batcher.ex’, line: 77]},
{:gen_server, :try_dispatch, 4,
[file: ‘gen_server.erl’, line: 601]},
{:gen_server, :handle_msg, 5,
[file: ‘gen_server.erl’, line: 667]},
{:proc_lib, :init_p_do_apply, 3,
[file: ‘proc_lib.erl’, line: 247]}]}

7/12/2018, 7:51:22 PM Batch Canceled #3 #4
7/12/2018, 7:51:22 PM Crash batch
{{:badmatch, {:error, :push}},
[{BorsNG.GitHub, :push!, 3,
[file: ‘lib/github/github.ex’, line: 63]},
{BorsNG.Worker.Batcher, :complete_batch, 3,
[file: ‘lib/worker/batcher.ex’, line: 381]},
{BorsNG.Worker.Batcher, :maybe_complete_batch, 1,
[file: ‘lib/worker/batcher.ex’, line: 368]},
{BorsNG.Worker.Batcher, :handle_cast, 2,
[file: ‘lib/worker/batcher.ex’, line: 77]},
{:gen_server, :try_dispatch, 4,
[file: ‘gen_server.erl’, line: 601]},
{:gen_server, :handle_msg, 5,
[file: ‘gen_server.erl’, line: 667]},
{:proc_lib, :init_p_do_apply, 3,
[file: ‘proc_lib.erl’, line: 247]}]}
7/12/2018, 7:21:38 PM Batch Failed #3 #4 #5 #6 #7


#2

Is protection turned on on your master branch?


#3

Yes, thanks, that seemed to be the issue. So on that note, how do I enforce other checks w/o branch protections? I use pullapprove and have requirements for CI to pass before allowing it to be added to the queue to ensure testing is working.

thanks!


#4

nm… I found the pr_status configuration which is what I needed! thanks